Conversation
API Project : Initial Setup
update Involvement API when a new like is added
Like and counter functions.
Item counter test
JavaScript capstone project - API-based webapp
AnselemOdims
left a comment
AnselemOdims
left a comment
There was a problem hiding this comment.
Hi team,
You have been doing a tremendous job so far 👌
There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlight 🎉
PR has a title and summary. ✔️
No linter errors ✔️
Required Changes ♻️
- Your presentation video is more than 5minutes. Kindly make sure that the video does not exceed 5mins.
- Please also check inline comments under the review
Optional suggestions
Comments with the [OPTIONAL] prefix are not a must to implement however, It's strongly recommended to work on them as they can make your code better.
Happy coding!👏👏👏
Please leave any questions or comments in the PR if you have any doubts or unclarity! You can tag me using @AnselemOdims for a quicker response
Note: Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| <div class="container" id="container"></div> | ||
| <div class="" id="modalContainer"></div> | ||
| <div id="overlay"></div> |
There was a problem hiding this comment.
- Please kindly make sure that the modal is scrollable, because at the moment the scrolling stops if you have a lot of comments and you might not be able to add new comments.
|
|
||
| show.appendChild(options); | ||
| options.appendChild(commentBtn); | ||
| options.appendChild(reservationBtn); |
There was a problem hiding this comment.
- Since the reservation was not implemented, I think it would be a good idea to remove the
Reservation button
| newLike(item_id) { | ||
| fetch('https://us-central1-involvement-api.cloudfunctions.net/capstoneApi/apps/WXzERyUj1Xacp8cuF1ms/likes', { | ||
| method: 'POST', | ||
| body: JSON.stringify({ | ||
| item_id, | ||
| }), | ||
| headers: { | ||
| 'Content-type': 'application/json; charset=UTF-8', | ||
| }, | ||
| }) | ||
| .then((response) => response.text()); | ||
| } |
There was a problem hiding this comment.
- Please kindly stick to using
async and awaitfor all asynchronous operations
medaminedev66
left a comment
medaminedev66
left a comment
There was a problem hiding this comment.
Hi @amrendrakind and @zkr024 😃,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Highlights
- Async and await with the fetch methods were used to send and receive data. Great job 👍
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| </header> | ||
| <div class="container" id="container"></div> | ||
| <div class="" id="modalContainer"></div> | ||
| <div id="overlay"></div> |
There was a problem hiding this comment.
- As requested by the previous reviewer, it would be nicer to make the modal scrollable so the user is able to scroll and close the modal. As you see in the screenshot below, the modal doesn't fit all the desktop screen sizes. To solve this problem, I would recommend adding a vertical scroll bar to the modal. Try to use dev tools to test your modal on different desktop screen sizes.
There was a problem hiding this comment.
Thank you for the feedback. We have added the scroll option to the modal.
**STATUS: APPROVED 🟢 **Hi @team,Great work on making the changes requested by a previous reviewer 👏🏻 Your project is complete! . There is nothing else to say other than... it's time to merge it 🍾🚢
Cheers and Happy coding! 👏 👏 👏 Feel free to leave any questions or comments in the PR thread by mentioning my Github username if something is not 100% clear. As described in the Code reviews limits policy you have 2 more limited reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form. |
. Congratulations! 🎉💯🌟
5 participants
API implementation.