Skip to content

Commit

Permalink
chore: upgrade to Node 14 (sumup-oss#734)
Browse files Browse the repository at this point in the history
  • Loading branch information
Robin Métral authored Dec 4, 2020
1 parent c865435 commit 8abe919
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 10 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/chromatic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v1
- name: Use Node.js v10
- name: Use Node.js v14
uses: actions/setup-node@v1
with:
node-version: 10.x
node-version: 14.x
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v1
- name: Use Node.js v10
- name: Use Node.js v14
uses: actions/setup-node@v1
with:
node-version: 10.x
node-version: 14.x
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v1
- name: Use Node.js v10
- name: Use Node.js v14
uses: actions/setup-node@v1
with:
node-version: 10.x
node-version: 14.x
- name: Get yarn cache directory path
id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
lts/dubnium
lts/fermium
4 changes: 1 addition & 3 deletions src/components/CurrencyInput/CurrencyInput.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,7 @@ describe('CurrencyInput', () => {
expect(input.value).toBe('1,234.56');
});

// FIXME: Our current Node version only supports English locales.
// Unskip when we upgrade to Node 13+.
it.skip('should format a de-DE amount correctly', () => {
it('should format a de-DE amount correctly', () => {
const { getByLabelText } = render(
<CurrencyInput
locale="de-DE"
Expand Down

0 comments on commit 8abe919

Please sign in to comment.