Skip to content

Commit

Permalink
Upgrade to Node 16 (sumup-oss#1556)
Browse files Browse the repository at this point in the history
* Upgrade to Node 16

* Test on multiple Node versions

* Improve code scanning action
  • Loading branch information
connor-baer authored Apr 28, 2022
1 parent d3fb618 commit 2f3a0d9
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/chromatic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ jobs:
chromatic:
runs-on: ubuntu-latest
steps:
- name: Setup Node.js v14
- name: Setup Node.js v16
uses: actions/setup-node@v1
with:
node-version: 14.x
node-version: 16.x

- name: Checkout repository
uses: actions/checkout@v2
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,14 @@ on: [push]
jobs:
ci:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16]
steps:
- name: Setup Node.js v14
- name: Setup Node.js ${{ matrix.node }}
uses: actions/setup-node@v1
with:
node-version: 14.x
node-version: ${{ matrix.node }}

- name: Checkout repository
uses: actions/checkout@v2
Expand Down Expand Up @@ -57,7 +60,7 @@ jobs:
token: ${{ secrets.CODECOV_TOKEN }}

- name: Create release PR or publish to npm
if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/next' || github.ref == 'refs/heads/canary'
if: (github.ref == 'refs/heads/main' || github.ref == 'refs/heads/next' || github.ref == 'refs/heads/canary') && matrix.node == 16
uses: changesets/action@master
with:
publish: yarn release
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/cna.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,14 @@ on:
jobs:
test:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16]
steps:
- name: Setup Node.js v14
- name: Setup Node.js ${{ matrix.node }}
uses: actions/setup-node@v1
with:
node-version: 14.x
node-version: ${{ matrix.node }}

- name: Checkout repository
uses: actions/checkout@v2
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
name: Code Scanning

on:
push:
branches: [main]
pull_request:
branches: [main]
schedule:
# At 7pm every Thursday
- cron: '0 19 * * 4'

jobs:
Expand All @@ -19,10 +23,10 @@ jobs:

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v1
uses: github/codeql-action/init@v2
# Override language selection by uncommenting this and choosing your languages
with:
languages: javascript
languages: typescript

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v1
uses: github/codeql-action/analyze@v2
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
lts/fermium
lts/gallium
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ To start contributing to SumUp Open Source projects, please accept our [Contribu

### Prerequisites

- [Node.js v14](https://nodejs.org/)
- [Node.js v16](https://nodejs.org/)
- [Yarn 1](https://classic.yarnpkg.com/en/docs/install)

### Installation
Expand Down
2 changes: 1 addition & 1 deletion packages/create-sumup-next-app/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ A

## 💻 Prerequisites

- You should have **Node.js** installed at a version equal or above **`v10.13.0`**. If you cannot do that, see the Troubleshooting section for ways around this requirement.
- You should have **Node.js** installed at a version equal or above **`v14.17.0`**. If you cannot do that, see the Troubleshooting section for ways around this requirement.
- At the moment this project reqires **`yarn`** to be installed on your system. Yarn is a package manager for JavaScript. You can read how to install the Yarn CLI in [their documentation](https://yarnpkg.com/en/docs/install).

## ✨ Setting up a new SumUp Next.js project
Expand Down

0 comments on commit 2f3a0d9

Please sign in to comment.