Simpler builds #630
Merged
Simpler builds #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild code and allows for incremental typescript compilation since the targets are the same always
dreamofabear
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor AVA integration to use the ESM output of TypeScript.
This change lets us only have one tsconfig for each environment, and avoid creating commonjs outputs just for testing.
Why was the previous approach less ideal? Incremental TypeScript compilation doesn't understand the change between output formats. Each time a developer on the project would switch between
testandbuildthe result would be cached from the previous build (but now with the wrong output).With this change, TypeScript is always generating ESM output, and AVA has been configured to use it.