Refactor Dist Output #465
Merged
Refactor Dist Output #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will need to be a minor release since we're still pre 1.0.0, but changes the output names and locations. |
dreamofabear
approved these changes
May 6, 2019
| document.addEventListener('DOMContentLoaded', function() { | ||
| MainThread.upgradeElement(document.getElementById('upgrade-me'), '/dist/worker.safe.js'); | ||
| }, false); | ||
| </script> |
There was a problem hiding this comment.
Intentionally removing nomodule support here?
There was a problem hiding this comment.
Yes, the amp builds do not generate a nomodule output. The expectation is AMP as a consumer will perform the work of transpiling this output.
Do you think this is a concern?
* Do not let Babel transpile template literals * Keep whitespace removal, allow babel + closure to compress other objects
Thought was to release as |
|
0.11.0 SGTM. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
syntaxnpm proposal, allowing bundlers to selectively choose modern JS for an expected module output.Solution
Updated
diststructure:Importantly each sub dependency is nested, to allow for the node resolution algorithm to correctly grab relatively modern JS versus transpiled to ES5 code.
The matrix for features enabled per build:
Todo
ampversion.