Transferables #361
Transferables #361
Conversation
…ved during build process.
…ers the Mutation Phase
|
Woot! Ready for review now. |
| authorURL: string; | ||
| domURL: string; | ||
|
|
||
| // ---- Optional Overrides |
There was a problem hiding this comment.
Just to make sure this is tracked: we'll need to update AMP's side once this is being upgraded.
| */ | ||
| export function upgradeElement(baseElement: Element, workerDOMUrl: string, callbacks?: WorkerCallbacks, debug?: boolean): Promise<WorkerDom | null> { | ||
| export function upgradeElement(baseElement: Element, domURL: string, longTask?: LongTaskFunction): Promise<Worker | null> { |
There was a problem hiding this comment.
Hmm. Why not just use the configuration struct here? There's always something comes up to add to this api.
There was a problem hiding this comment.
Likely should just use the struct since we're changing the signature anyway. Good idea.
| if (sanitizer && !sanitizer.sanitize(node)) { | ||
| return null; | ||
| // If `node` is removed by the sanitizer, don't store it and return null. | ||
| if (sanitizer && !sanitizer.sanitize(node)) { |
There was a problem hiding this comment.
Probably should defer given the focus of this PR, but if we sanitization is meaningful here, we either should not create a node until it has been sanitized (looks like only by name in this case), or we should create the node via template and re-import into the doc post-sanitization.
Ready for review now.
This PR moves the transfer format over to
ArrayBuffers comprised ofUint16Arraymembers.Still needs another merge with
master, will take a while since there have been so many changes.