Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copyright header #1097

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Remove copyright header #1097

merged 3 commits into from
Sep 23, 2021

Conversation

samouri
Copy link
Member

@samouri samouri commented Sep 23, 2021

summary

Per conversations with OpenJS and Google, we have permission to remove the notice at the top of each AMPHTML source file.

I believe this applies to all ampproject code: ampproject/amphtml#35717 (comment)

changes made

  • Project wide find/replace for CC header from years 2017 --> 2021
  • npx prettier --config .prettierrc --write **/*.ts

@samouri samouri self-assigned this Sep 23, 2021
@samouri samouri marked this pull request as ready for review September 23, 2021 19:55
demo/preact-dbmon/dbmon.css Outdated Show resolved Hide resolved
demo/preact-map/src/candidateMap.css Outdated Show resolved Hide resolved
onMouseLeave={handleMouseLeave}
/>
);
return <rect x={x} y={y} width="180" height="180" fill={fill} stroke="black" onMouseEnter={handleMouseEnter} onMouseLeave={handleMouseLeave} />;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? This is ugly/harder to read imo

Copy link
Member Author

@samouri samouri Sep 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the description above.
Don't take it up with me, take it up with the .prettierrc :)

Which for the record, I'm ok with changing. I have very little preference re. printWidth

demo/preact-map/src/candidateMap.jsx Show resolved Hide resolved
demo/preact-map/src/candidateTable.css Outdated Show resolved Hide resolved
demo/preact-todomvc/base.css Outdated Show resolved Hide resolved
demo/preact-todomvc/todomvc.css Outdated Show resolved Hide resolved
demo/react-map/src/candidateMap.css Outdated Show resolved Hide resolved
demo/react-map/src/candidateMap.jsx Show resolved Hide resolved
demo/react-map/src/candidateTable.css Outdated Show resolved Hide resolved
@samouri samouri merged commit da975ce into ampproject:main Sep 23, 2021
@samouri samouri deleted the rm-cc branch September 23, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants