Adds AMP Access Server support #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change article to be able to use client or server config - Respond with signed JWT on the API when auth is being accessed in server mode (type=server) - Change sample list to link to both client and server version of the articles
| A+VO47/P0H5U2SCXAkBY2ykmcZh+F1fMt3UFk48li6vWnHenRYKeJsPEQAm0ujgQ | ||
| v41z3Wnhg65zI8j1o+K9dc0qtgZ/Fsa8c7zTF8SC | ||
| -----END RSA PRIVATE KEY-----`; | ||
| var ONE_DAY = 1000 * 60 * 60 * 24; |
There was a problem hiding this comment.
Let's change expiration to 5 minutes.
|
LGTM with one request |
|
Changed timeout to 5 mins. |
| @@ -17,9 +17,26 @@ | |||
|
|
|||
| var express = require('express'); | |||
| var router = express.Router(); | |||
There was a problem hiding this comment.
what is this key for?
|
Would be great if we could add a few comments explaining what's going on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in server mode (type=server)
of the articles