Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional amp cache test domains #48

Merged
merged 1 commit into from
Aug 11, 2016
Merged

Add additional amp cache test domains #48

merged 1 commit into from
Aug 11, 2016

Conversation

dknecht
Copy link
Contributor

@dknecht dknecht commented Aug 10, 2016

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@sebastianbenz
Copy link
Collaborator

LGTM once the CLA is signed.

@dknecht
Copy link
Contributor Author

dknecht commented Aug 10, 2016

I signed it! CLA signed under CloudFlare

@dknecht dknecht closed this Aug 10, 2016
@dknecht dknecht reopened this Aug 10, 2016
@dknecht
Copy link
Contributor Author

dknecht commented Aug 11, 2016

@sebastianbenz I might have messed up the CLA bot when I closed and reopened by accident.

@sebastianbenz
Copy link
Collaborator

It should work if your commit's email address is one of the email addresses associated with your companies CLA.

@googlebot
Copy link

CLAs look good, thanks!

@sebastianbenz sebastianbenz merged commit 836ee94 into ampproject:master Aug 11, 2016
@sebastianbenz
Copy link
Collaborator

Now live at https://rocky-sierra-1919.herokuapp.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants