Fix accessibility and best practices issues#60
Merged
MarcoABCorrea merged 2 commits intomainfrom Nov 5, 2021
Merged
Conversation
sebastianbenz
requested changes
Nov 5, 2021
site/_includes/partials/demo.njk
Outdated
| </div> | ||
| <div class="bd-demo-code__result"> | ||
| <iframe id="bd-demo-iframe" src="{{examples}}bd-demo-carousel.html"></iframe> | ||
| <iframe id="bd-demo-iframe" src="{{examples}}bd-demo-carousel.html" aria-label="Demo preview"></iframe> |
Collaborator
There was a problem hiding this comment.
rename to: "Bento carousel demo preview"
Collaborator
There was a problem hiding this comment.
Also use title instead
site/_includes/partials/demo.njk
Outdated
| <button option="bd-demo-accordion" class="bd-button--light --inverted --uppercase">accordion</button> | ||
| <button option="bd-demo-sidebar" class="bd-button--light --inverted --uppercase">sidebar</button> | ||
| <button option="bd-demo-social-share" class="bd-button--light --inverted --uppercase">social share</button> | ||
| <bento-selector id="bd-demo-selector" aria-label="Demo selector button group"> |
Collaborator
There was a problem hiding this comment.
Try to make the labels explain what this is for: 'Select a Bento Demo'
site/_includes/partials/demo.njk
Outdated
| <button option="bd-demo-sidebar" class="bd-button--light --inverted --uppercase">sidebar</button> | ||
| <button option="bd-demo-social-share" class="bd-button--light --inverted --uppercase">social share</button> | ||
| <bento-selector id="bd-demo-selector" aria-label="Demo selector button group"> | ||
| <button option="bd-demo-carousel" class="bd-button--light --uppercase" aria-label="Button demo carousel">carousel</button> |
Collaborator
There was a problem hiding this comment.
You don't need to add the type in the label, that's already clear from the element type. Better: 'show carousel demo'
site/_includes/partials/header.njk
Outdated
| </nav> | ||
| {# {%- include './language-selector.njk' -%} #} | ||
| <button class="bd-header-burger" tabindex="0"> | ||
| <button class="bd-header-burger" tabindex="0" aria-label="Burger Menu"> |
Collaborator
There was a problem hiding this comment.
same as above, describe the action: 'Open menu'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #53