Update build paths to include src/bento/components#175
Merged
sebastianbenz merged 1 commit intoampproject:mainfrom Feb 11, 2022
Merged
Update build paths to include src/bento/components#175sebastianbenz merged 1 commit intoampproject:mainfrom
sebastianbenz merged 1 commit intoampproject:mainfrom
Conversation
alanorozco
approved these changes
Feb 10, 2022
Member
alanorozco
left a comment
alanorozco
left a comment
There was a problem hiding this comment.
@sebastianbenz Could we get a review? 🙂
| async function importComponents() { | ||
| const filePaths = await fg(path.join(EXTENSIONS_SRC, '**/1.0/README.md')); | ||
| const filePaths = await fg([ | ||
| path.join(EXTENSIONS_SRC, '**/1.0/README.md'), |
Collaborator
There was a problem hiding this comment.
Are there bento components still left in extensions? Or will they be moved on a 1 by 1 bases?
Member
There was a problem hiding this comment.
They'll all be moved, but there's some leftover. If it helps, we could move all of README.md and example/ into src/bento before merging this.
Collaborator
There was a problem hiding this comment.
I was just curious. Works for me as is.
sebastianbenz
approved these changes
Feb 11, 2022
Collaborator
sebastianbenz
left a comment
sebastianbenz
left a comment
There was a problem hiding this comment.
LGTM - thanks! Please let me know once all components have moved and we can remove the code for the extensions dir.
| async function importComponents() { | ||
| const filePaths = await fg(path.join(EXTENSIONS_SRC, '**/1.0/README.md')); | ||
| const filePaths = await fg([ | ||
| path.join(EXTENSIONS_SRC, '**/1.0/README.md'), |
Collaborator
There was a problem hiding this comment.
I was just curious. Works for me as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we migrate components within amphtml the location of their documentation is changing. This PR should ensure the new doc locations are picked up as well.
ampproject/amphtml#36461