Separate {% endexample %} tags from code blocks#161
Merged
sebastianbenz merged 3 commits intomainfrom Jan 12, 2022
unknown repository
Merged
Separate {% endexample %} tags from code blocks#161sebastianbenz merged 3 commits intomainfrom unknown repository
sebastianbenz merged 3 commits intomainfrom
unknown repository
Conversation
Contributor
Author
|
@patrickkettner FYI |
sebastianbenz
requested changes
Jan 10, 2022
Collaborator
sebastianbenz
left a comment
There was a problem hiding this comment.
These docs are imported from the amphtml repo and the endexample tags are injected automatically. The line space needs to be added here: https://github.com/ampproject/bentojs.dev/blob/main/gulpfile.js/importDocs.js#L40
Contributor
Author
@sebastianbenz Ah, got it, thanks! Added another commit to address that. Looks like this is not something I can test locally, so can you PTAL? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The closing {% endexample %} tags are currently placed on the same line as closing fenced code block tags (```). While Eleventy seems to render pages correctly, this still results in incorrect parsing of the markdown files by translation platforms (and by GitHub - see screenshot).
This PR adds extra line breaks to separate the {% endexample %} tags from code blocks so we can correctly parse the files for translation.