Skip to content

Separate {% endexample %} tags from code blocks#161

Merged
sebastianbenz merged 3 commits intomainfrom
unknown repository
Jan 12, 2022
Merged

Separate {% endexample %} tags from code blocks#161
sebastianbenz merged 3 commits intomainfrom
unknown repository

Conversation

@ilyaspiridonov
Copy link
Contributor

The closing {% endexample %} tags are currently placed on the same line as closing fenced code block tags (```). While Eleventy seems to render pages correctly, this still results in incorrect parsing of the markdown files by translation platforms (and by GitHub - see screenshot).
This PR adds extra line breaks to separate the {% endexample %} tags from code blocks so we can correctly parse the files for translation.

Screenshot 2022-01-05 at 17 59 33

@ilyaspiridonov
Copy link
Contributor Author

@patrickkettner FYI

Copy link
Collaborator

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These docs are imported from the amphtml repo and the endexample tags are injected automatically. The line space needs to be added here: https://github.com/ampproject/bentojs.dev/blob/main/gulpfile.js/importDocs.js#L40

@ilyaspiridonov
Copy link
Contributor Author

ilyaspiridonov commented Jan 12, 2022

These docs are imported from the amphtml repo and the endexample tags are injected automatically. The line space needs to be added here: https://github.com/ampproject/bentojs.dev/blob/main/gulpfile.js/importDocs.js#L40

@sebastianbenz Ah, got it, thanks! Added another commit to address that. Looks like this is not something I can test locally, so can you PTAL?

Copy link
Collaborator

@sebastianbenz sebastianbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sebastianbenz sebastianbenz merged commit 0b59e78 into ampproject:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants