If signer had to cap the AMP doc, don't sign and proxy full document. #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banaag
reviewed
Jun 23, 2020
packager/signer/signer_test.go
Outdated
| resp.Header().Set("Content-Type", "text/html") | ||
| resp.Write(customFakeBody) | ||
| } | ||
| resp := this.get(this.T(), this.new(urlSets), "/priv/doc?sign="+url.QueryEscape(this.httpsURL()+fakePath)) |
There was a problem hiding this comment.
This code doesn't look up to date. In particular, I remember replacing this.get() during the FIXIT in PR ec46ffd
There was a problem hiding this comment.
Thanks, fixed.
banaag
approved these changes
Jun 23, 2020
twifkak
approved these changes
Jun 23, 2020
packager/signer/signer_test.go
Outdated
Comment on lines
1044
to
1045
| veryLongArray := [maxBodyLength + uncappedTailLength]string{} | ||
| veryLongString := strings.Join(veryLongArray[:], "a") |
There was a problem hiding this comment.
I think you can replace this with a call to https://golang.org/pkg/strings/#Repeat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.