Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "metrics" Prometheus endpoint - total requests by type and code. #417

Merged
merged 12 commits into from
May 11, 2020
Merged

Add "metrics" Prometheus endpoint - total requests by type and code. #417

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7b639d9
Refactor mux - introduce the routing matrix.
MichaelRybak May 5, 2020
d49c0ab
Add 'metrics' Prometheus endpoint - total requests by type and code.
MichaelRybak May 6, 2020
2877a67
Sync with master
MichaelRybak May 6, 2020
2273306
Add a comment explaining that there'll always be a matching rule.
MichaelRybak May 6, 2020
860e78b
Revert go.mod and go.sum
MichaelRybak May 7, 2020
374e61c
Upd
MichaelRybak May 7, 2020
960f6ba
Merge branch 'master' of https://github.com/ampproject/amppackager in…
MichaelRybak May 7, 2020
b9c70dd
Fix build.
MichaelRybak May 7, 2020
e4c014b
Cleanup - revert files touched only by gofmt.
MichaelRybak May 7, 2020
8473768
Separate default rule into a separate field in mux.
MichaelRybak May 11, 2020
e01d42a
Run prometheus test scenarios in isolation and together.
MichaelRybak May 11, 2020
74fa58a
Fix spelling.
MichaelRybak May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix spelling.
  • Loading branch information
@MichaelRybak
MichaelRybak committed May 11, 2020
commit 74fa58a4bff2c0a07f0154df7d7756a1932311bd
2 changes: 1 addition & 1 deletion packager/mux/mux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ const promResultHeader = `

// TestPrometheusMetrics tests counting of Prometheus metrics. Test each
// scenario in isolation to make sure each of them works, then test them
// alltogether to make sure they don't interfere with each other.
// altogether to make sure they don't interfere with each other.
func TestPrometheusMetrics(t *testing.T) {
nopHandler := http.Handler(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {}))

Expand Down