Remove PackagerBase. #113
Merged
Remove PackagerBase. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alin04
reviewed
Sep 19, 2018
README.md
Outdated
|
|
||
| #### Productionizing | ||
|
|
||
| For now, productionizing is a bit manual. We would love to see scripts or |
There was a problem hiding this comment.
Maybe omit this last sentence?
README.md
Outdated
| comamndline flags; just make sure chrome://flags/#enable-signed-http-exchange is | ||
| enabled. | ||
|
|
||
| #### Replicating |
There was a problem hiding this comment.
Redundancy? I always think of replication in the context of data replication...
twifkak
added a commit
to twifkak/amppackager
that referenced
this pull request
Sep 19, 2018
|
OK, done on #111, PTAL there. |
twifkak
force-pushed
the
packager_base
branch
from
b633f01 to
1eb4f2a
Compare
alin04
approved these changes
Sep 19, 2018
twifkak
force-pushed
the
packager_base
branch
from
1eb4f2a to
fc35ab0
Compare
It is confusing, and also wrong, now that the validity-url must be same-origin with the signed URL. Instead, the behavior is thus: 1. validity-url is computed using the origin of the signed URL. It doesn't matter if this doesn't actually exist; the browser doesn't currently fetch it. 2. In development, the cert-url is localhost, so that you can test with a browser. 3. In production, the cert-url is computed using the origin of the signed URL. The README.md states that publishers must configure this when productionizing.
twifkak
force-pushed
the
packager_base
branch
from
fc35ab0 to
be94831
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is confusing, and also wrong, now that the validity-url must be
same-origin with the signed URL. Instead, the behavior is thus:
doesn't matter if this doesn't actually exist; the browser doesn't
currently fetch it.
a browser.
signed URL. The README.md states that publishers must configure this
when productionizing.
Fixes #79.
Ignore the first 4 commits; they will be rebased away.