You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead, they should follow a builder pattern, something like Request(t, handler, "/blah").Headers({...}).Body("foo").Get(). That way the names are not unreadable, and we don't have a combinatorial explosion of the different variants of Get().
The text was updated successfully, but these errors were encountered:
There are a bunch of cryptically named functions to issue fake HTTP requests to a handler and record their responses:
amppackager/packager/testing/testing.go
Lines 92 to 122 in bf061be
Instead, they should follow a builder pattern, something like
Request(t, handler, "/blah").Headers({...}).Body("foo").Get()
. That way the names are not unreadable, and we don't have a combinatorial explosion of the different variants of Get().The text was updated successfully, but these errors were encountered: