Slowly migrate AMP to a state where we can obfuscate all properties. #9875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
reviewed
Jun 13, 2017
src/utils/object.js
Outdated
| if (opt_initial) { | ||
| return /** @type {!JsonObject} */ (opt_initial); | ||
| } | ||
| return /** @type {!JsonObject} */ ({}); |
There was a problem hiding this comment.
should we do Object.create(null) here
There was a problem hiding this comment.
Good call. Just made the function pass through to map
erwinmombay
approved these changes
Jun 13, 2017
erwinmombay
approved these changes
Jun 13, 2017
Uses the type system to ensure that objects that must be treated as non-obfuscateable are using bracket notation for property access. This is a first PR of many.
erwinmombay
reviewed
Jun 14, 2017
| */ | ||
| this.config_ = /** @type {JSONType} */ ({}); | ||
| this.config_ = /** @type {JsonObject} */ ({}); |
There was a problem hiding this comment.
would it be better to call dict() here? (besides the implication of adding additional code to the binary)
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the type system to ensure that objects that must be treated as non-obfuscateable are using bracket notation for property access.
This is a first PR of many. Part of #9876