Added a very basic version of analytics for AMP. #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * limitations under the License. | ||
| */ | ||
|
|
||
| amp-analytics { |
There was a problem hiding this comment.
This is too late. We have to move this definition to amp.css.
There was a problem hiding this comment.
done in a previous commit.
|
Please reference in the description:
|
| { | ||
| "on": "TAP", | ||
| "request": "default", | ||
| "selector": "" |
There was a problem hiding this comment.
What does empty selector do?
There was a problem hiding this comment.
undefined behavior for now. I removed it since the implementation for that part is not ready yet. Once we start working on it, we can define what empty selector does.
| * @param {string} formatString The request string to be expanded | ||
| * @param {RegExp} expression The regular expression used to detect request | ||
| * templates | ||
| * @param {Object.<string, string> requests Map of requests to lookup template |
|
Cool. I think we are pretty close. But one request: could you please respond to each comment we make? It makes it a lot easier to review. |
|
Good. So, two more actions:
Otherwise, LGTM. |
So far, the tag parses the inline config and uses one builtin type to listen for document.load events and sends a GET request when that happens. There is premitive support for request templates and platform variables. Things that are pending: - Support for more platform variables (future PR) - Better instrumentation class (future PR) - User specified variables (future PR) and more...
|
LGTM |
dvoytenko
added a commit
that referenced
this pull request
Dec 4, 2015
Added a very basic version of analytics for AMP.
|
👍 |
|
Woot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR in a series of PRs to implement the spec outlined in #871.
In this commit, the tag parses the inline config and uses one builtin type to listen for
document.load events and sends a GET request when that happens. There is
primitive support for request templates and platform variables.
Things that are still to come: