Support a template-enabled [submitting] element #9442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
requested changes
May 19, 2017
extensions/amp-form/0.1/amp-form.js
Outdated
| } else { | ||
| xhrUrl = this.xhrAction_; | ||
| body = new FormData(this.form_); | ||
| for (const key in opt_extraValues) { | ||
| body.append(key, opt_extraValues[key]); | ||
| } | ||
| values = {}; | ||
| const entries = body.entries(); |
There was a problem hiding this comment.
Iterators are not supported everywhere.
jridgewell
approved these changes
May 19, 2017
aghassemi
suggested changes
May 19, 2017
| @@ -440,17 +440,20 @@ export class AmpForm { | |||
| */ | |||
| doXhr_(opt_extraValues) { | |||
| const isHeadOrGet = this.method_ == 'GET' || this.method_ == 'HEAD'; | |||
| const values = this.getFormAsObject_(opt_extraValues); | |||
| this.renderTemplate_(values); | |||
There was a problem hiding this comment.
this will render all templates which causes unnecessary rendering of success/failure templates as well. would be nice if renderTemplate could take the type of target template.
There was a problem hiding this comment.
It should just render whatever template matches the current form state.
There was a problem hiding this comment.
Justin's assessment is correct, it only render's the current state's template. In this case it's the FormState_.SUBMITTING state.
| @@ -564,6 +564,7 @@ amp-iframe iframe { | |||
| /** | |||
| * Forms error/success messaging containers should be hidden at first. | |||
| */ | |||
| form [submitting], | |||
There was a problem hiding this comment.
validator file needs to be changed to support a similar rule to spec_name: "FORM > DIV [submit-success]"
|
This is now live in prod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8601