Force upgrade sticky ad to 1.0 #9042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are we updating only tests? How would the actual upgrade happen? Are you saying that you are deploying 1.0 to 0.1 instead? |
|
Yes. Use the file |
dvoytenko
approved these changes
Apr 28, 2017
|
LGTM, but please wait for @erwinmombay |
|
ping @erwinmombay |
erwinmombay
reviewed
May 2, 2017
gulpfile.js
Outdated
| @@ -378,6 +378,10 @@ function buildExtension(name, version, hasCss, options, opt_extraGlobs) { | |||
| options = options || {}; | |||
| options.extraGlobs = opt_extraGlobs; | |||
| var path = 'extensions/' + name + '/' + version; | |||
| if (name == 'amp-sticky-ad' && version == '0.1') { | |||
| // sticky-ad upgrade, 0.1 is deprecated. | |||
There was a problem hiding this comment.
please add explanation why we do this
erwinmombay
approved these changes
May 2, 2017
erwinmombay
reviewed
May 2, 2017
gulpfile.js
Outdated
| if (name == 'amp-sticky-ad' && version == '0.1') { | ||
| // Special case for sticky-ad upgrade. | ||
| // To deprecate 0.1, replace the build path so that amp-sticky-ad-0.1.js | ||
| // is built from extensions/amp-sticky-ad/1.0/amp-sticky-ad.js |
There was a problem hiding this comment.
can you explain further "why" we want this.
There was a problem hiding this comment.
how do you like the explanation now : )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6169
cc @jasti
I will remove the actually file once the upgrade is stable in prod.