Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure to do the dom mutation inside a deferMutate #862

Merged
merged 1 commit into from
Nov 4, 2015

Conversation

erwinmombay
Copy link
Member

No description provided.

@ampsauce
Copy link

ampsauce commented Nov 4, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: 1fef51ba1455c7c3bdc1a2f249358f60f00089c6
Build details: https://travis-ci.org/ampsauce/amphtml/builds/89319706

(Please note that this is a fully automated comment.)


this.element.removeChild(this.iframe_);
this.toggleFallback(true);
// TODO: (erwinm) check the performance of the append here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's basically it. TODO is done :)

@dvoytenko
Copy link
Contributor

LGTM

@@ -245,7 +245,7 @@ export function installAd(win) {

// Triggered by context.noContentAvailable() inside the ad iframe.
const unlisten = listen(this.iframe_, 'no-content', () => {
this.noContentHandler_();
this.deferMutate(this.noContentHandler_.bind(this));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvoytenko moved the deferMutate call here instead to make my test pass.

erwinmombay added a commit that referenced this pull request Nov 4, 2015
fix: make sure to do the dom mutation inside a `deferMutate`
@erwinmombay erwinmombay merged commit 36cc8af into ampproject:master Nov 4, 2015
@ampsauce
Copy link

ampsauce commented Nov 4, 2015

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 75eb290
Build details: https://travis-ci.org/ampsauce/amphtml/builds/89323625

(Please note that this is a fully automated comment.)

This was referenced Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants