fix: make sure to do the dom mutation inside a deferMutate
#862
Conversation
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 1fef51ba1455c7c3bdc1a2f249358f60f00089c6 (Please note that this is a fully automated comment.) |
|
|
||
| this.element.removeChild(this.iframe_); | ||
| this.toggleFallback(true); | ||
| // TODO: (erwinm) check the performance of the append here |
There was a problem hiding this comment.
That's basically it. TODO is done :)
|
LGTM |
erwinmombay
force-pushed
the
fix-race-pt2
branch
from
1fef51b
to
75eb290
Compare
| @@ -245,7 +245,7 @@ export function installAd(win) { | |||
|
|
|||
| // Triggered by context.noContentAvailable() inside the ad iframe. | |||
| const unlisten = listen(this.iframe_, 'no-content', () => { | |||
| this.noContentHandler_(); | |||
| this.deferMutate(this.noContentHandler_.bind(this)); | |||
There was a problem hiding this comment.
@dvoytenko moved the deferMutate call here instead to make my test pass.
fix: make sure to do the dom mutation inside a `deferMutate`
|
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 75eb290 (Please note that this is a fully automated comment.) |
No description provided.