Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates README to welcome new contributors and remove some redundancy #7769

Merged
merged 4 commits into from
Feb 24, 2017
Merged

Updates README to welcome new contributors and remove some redundancy #7769

merged 4 commits into from
Feb 24, 2017

Conversation

mrjoro
Copy link
Member

@mrjoro mrjoro commented Feb 23, 2017

Fixes Issue #7669.

  • Adds context/links for new contributors to AMP.
  • Gives preference to links to ampproject.org instead of inlining details of AMP markup/etc.
  • Removes reference to AMP being used for "static" pages.
  • Moves the release schedule information to a separate doc.

cc @bpaduch @erwinmombay

@mrjoro mrjoro added this to the Docs Updates milestone Feb 23, 2017
@mrjoro mrjoro requested a review from cramforce February 23, 2017 22:31
@mrjoro mrjoro mentioned this pull request Feb 23, 2017
Closed
cramforce
cramforce approved these changes Feb 23, 2017
View reviewed changes
Copy link
Member

@cramforce cramforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so awesome! One small comment.

contributing/release-schedule.md Outdated

We push a new release of AMP to all AMP pages every week on Thursday. The more detailed schedule is as follows:

- Every Wednesday we cut a green release from our `master` branch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead of green say "we cut the release at the latest commit that passed all tests."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@cramforce cramforce merged commit db5d74c into ampproject:master Feb 24, 2017
@mrjoro mrjoro mentioned this pull request Feb 27, 2017
Closed
@mrjoro mrjoro deleted the mrjoro-readme branch March 15, 2017 14:52
mrjoro added a commit to mrjoro/amphtml that referenced this pull request Apr 28, 2017
@mrjoro
Updates README to welcome new contributors and remove some redundancy (…
4fd43c3 
…ampproject#7769)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cramforce cramforce cramforce approved these changes

Assignees
No one assigned
Labels
Related to: Documentation
Projects
None yet
Milestone
Docs Updates
Development

Successfully merging this pull request may close these issues.
2 participants
@mrjoro @cramforce