Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A integration tests #5812

Merged
merged 16 commits into from
Nov 3, 2016
Merged

A4A integration tests #5812

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
31a42ab
First draft of full integration tests for A4A.
Oct 25, 2016
e916def
First draft of full integration tests for A4A.
Oct 25, 2016
9c5d96b
Got tests of exception conditions working. Refactored some common st…
Oct 25, 2016
9a08b60
Refactored XDom and friendly iframe tests to helpers.
Oct 25, 2016
af29b01
Added tests.
Oct 25, 2016
0de8f8e
Resolved merge conflicts.
Oct 25, 2016
481fe00
Centralized visibility check and updated visibility test.
Oct 26, 2016
3051838
Moved all A4A tests to using central visibility test.
Oct 26, 2016
c6d3e55
Lint fixes.
Oct 27, 2016
4fd797c
Changed custom expectations to local functions.
Nov 1, 2016
1848de6
Replaced stringToArrayBuffer with utf8Encode.
Jan 1, 2015
59e9634
Fixed visibility assertion.
Nov 1, 2016
0c72a3c
Lint fixes.
Nov 1, 2016
487d149
Added a comment (partly in order to get Travis to re-run).
Nov 2, 2016
fbda8c8
Changes in response to reviews.
Nov 3, 2016
b384663
Rebased and fixed small rebase error.
Nov 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rebased and fixed small rebase error.
  • Loading branch information
Terran Lane committed Nov 3, 2016
commit b384663e0f2854ea8377f3819c10079b4221b531
2 changes: 1 addition & 1 deletion extensions/amp-a4a/0.1/test/test-amp-a4a.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ describe('amp-a4a', () => {
}

function buildCreativeArrayBuffer() {
return stringToArrayBuffer(buildCreativeString());
return utf8Encode(buildCreativeString());
}

function verifyNonAMPRender(a4a) {
Expand Down