add back loop feature. #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dvoytenko can you check if carousel integration tests still fails for you locally? |
Merged
erwinmombay
force-pushed
the
loop
branch
2 times, most recently
from
8280b1f to
d3afb63
Compare
|
@dvoytenko this is ready for review. |
| if (nextItemIndex < 0) { | ||
| return length + (nextItemIndex % length); | ||
| } | ||
| return nextItemIndex % length; |
There was a problem hiding this comment.
(index + step + length) % length is a bit shorter
|
LGTM with a couple of comments. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need to create a new one cause of private -> public switch.
need to finish documentation
TODOS: