Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable flaky video test #40175

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Reenable flaky video test #40175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions test/integration/test-video-players-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,7 @@ export function runVideoPlayerIntegrationTests(
});
});

// TODO(#40115): fix this flaky test
it.skip('should trigger pause analytics when the video pauses', function () {
it('should trigger pause analytics when the video pauses', function () {
let pauseButton;

return getVideoPlayer({
Expand All @@ -202,8 +201,7 @@ export function runVideoPlayerIntegrationTests(
});
});

// TODO(#40115): fix this flaky test
it.skip('should trigger session analytics when a session ends', function () {
it('should trigger session analytics when a session ends', function () {
let pauseButton;

return getVideoPlayer({
Expand Down Expand Up @@ -381,8 +379,7 @@ export function runVideoPlayerIntegrationTests(
this.timeout(timeout);

describe('play/pause', () => {
// TODO(#40115): fix this flaky test
it.skip('should play when in view port initially', () => {
it('should play when in view port initially', () => {
return getVideoPlayer({outsideView: false, autoplay: true}).then(
(r) => {
return listenOncePromise(r.video, VideoEvents_Enum.PLAYING);
Expand Down Expand Up @@ -593,8 +590,8 @@ export function runVideoPlayerIntegrationTests(
video.setAttribute('id', 'myVideo');
video.setAttribute('controls', '');
video.setAttribute('layout', 'fixed');
video.setAttribute('width', '300px');
video.setAttribute('height', '50vh');
video.setAttribute('width', '300');
video.setAttribute('height', '300');

video.style.position = 'absolute';
video.style.top = top;
Expand Down
6 changes: 3 additions & 3 deletions test/integration/test-video-players.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ describes.sandboxed('amp-video-iframe', {}, (env) => {
);
});

describes.sandboxed('amp-youtube', {}, (env) => {
// TODO(#40181): Youtube tests not working on Circle.
describes.sandboxed.skip('amp-youtube', {}, (env) => {
runVideoPlayerIntegrationTests(
env,
(fixture) => {
Expand All @@ -60,8 +61,7 @@ describes.sandboxed('amp-dailymotion', {}, (env) => {
);
});

// TODO(#39857): Unskip when integration is fixed.
describes.sandboxed.skip('amp-3q-player', {}, (env) => {
describes.sandboxed('amp-3q-player', {}, (env) => {
runVideoPlayerIntegrationTests(
env,
(fixture) => {
Expand Down
Loading