Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📦 Update dependency prettier to v3.0.2 #39373

Merged
merged 2 commits into from
Aug 15, 2023
Merged

📦 Update dependency prettier to v3.0.2 #39373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c6875f
📦 Update dependency prettier to v3.0.2
renovate[bot] Aug 15, 2023
ad714fe
`amp lint --fix`
danielrozenberg Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions extensions/amp-ad/0.1/test/test-amp-ad-xorigin-iframe-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,9 +407,8 @@ describes.sandboxed('amp-ad-xorigin-iframe-handler', {}, (env) => {
sentinel: 'amp3ptest' + testIndex,
});

const data3 = await iframe.expectMessageFromParent(
'embed-size-changed'
);
const data3 =
await iframe.expectMessageFromParent('embed-size-changed');

expect(data3).to.jsonEqual({
requestedWidth: 114,
Expand Down
5 changes: 2 additions & 3 deletions extensions/amp-list/0.1/test-e2e/test-load-more-auto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@ describes.endtoend(
'none'
);

const failedIndicator = await controller.findElement(
'[load-more-failed]'
);
const failedIndicator =
await controller.findElement('[load-more-failed]');
await expect(failedIndicator).to.be.ok;
await expect(
controller.getElementCssValue(failedIndicator, 'display')
Expand Down
5 changes: 2 additions & 3 deletions extensions/amp-list/0.1/test-e2e/test-load-more-manual.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,8 @@ describes.endtoend(
'none'
);

const failedIndicator = await controller.findElement(
'[load-more-failed]'
);
const failedIndicator =
await controller.findElement('[load-more-failed]');
await expect(failedIndicator).to.be.ok;
await expect(
controller.getElementCssValue(failedIndicator, 'display')
Expand Down
20 changes: 8 additions & 12 deletions extensions/amp-subscriptions/0.1/test/test-viewer-platform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,8 @@ describes.fakeWin('ViewerSubscriptionPlatform', {amp: true}, (env) => {
'entitlements': entitlementData,
}));

const resolvedEntitlement = await viewerPlatform.verifyAuthToken_(
'faketoken'
);
const resolvedEntitlement =
await viewerPlatform.verifyAuthToken_('faketoken');
expect(resolvedEntitlement).to.be.not.undefined;
expect(resolvedEntitlement.service).to.equal(entitlementData.service);
expect(resolvedEntitlement.source).to.equal('viewer');
Expand All @@ -241,9 +240,8 @@ describes.fakeWin('ViewerSubscriptionPlatform', {amp: true}, (env) => {
'entitlements': [entitlementData],
}));

const resolvedEntitlement = await viewerPlatform.verifyAuthToken_(
'faketoken'
);
const resolvedEntitlement =
await viewerPlatform.verifyAuthToken_('faketoken');
expect(resolvedEntitlement).to.be.not.undefined;
expect(resolvedEntitlement.service).to.equal(entitlementData.service);
expect(resolvedEntitlement.source).to.equal('viewer');
Expand Down Expand Up @@ -287,9 +285,8 @@ describes.fakeWin('ViewerSubscriptionPlatform', {amp: true}, (env) => {
},
}));

const resolvedEntitlement = await viewerPlatform.verifyAuthToken_(
'faketoken'
);
const resolvedEntitlement =
await viewerPlatform.verifyAuthToken_('faketoken');
expect(resolvedEntitlement).to.be.not.undefined;
expect(resolvedEntitlement.service).to.equal('local');
expect(resolvedEntitlement.granted).to.be.equal(true);
Expand Down Expand Up @@ -317,9 +314,8 @@ describes.fakeWin('ViewerSubscriptionPlatform', {amp: true}, (env) => {
},
}));

const resolvedEntitlement = await viewerPlatform.verifyAuthToken_(
'faketoken'
);
const resolvedEntitlement =
await viewerPlatform.verifyAuthToken_('faketoken');
expect(resolvedEntitlement).to.be.not.undefined;
expect(resolvedEntitlement.service).to.equal('local');
expect(resolvedEntitlement.granted).to.be.equal(true);
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
"postcss": "8.3.11",
"postcss-import": "14.0.2",
"posthtml": "0.16.5",
"prettier": "3.0.1",
"prettier": "3.0.2",
"react": "17.0.2",
"react-dom": "17.0.2",
"rocambole": "0.7.0",
Expand Down
10 changes: 4 additions & 6 deletions test/e2e/test-amp-bind-live-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@ describes.endtoend(

describe('with <amp-live-list>', () => {
it('should detect bindings in initial live-list elements', async () => {
const liveListChildren = await controller.findElements(
'#liveListItems > *'
);
const liveListChildren =
await controller.findElements('#liveListItems > *');
await expect(liveListChildren.length).to.equal(1);

const existingItem = await controller.findElement('#liveListItem1');
Expand All @@ -38,9 +37,8 @@ describes.endtoend(
// TODO(cvializ,choumx): Configure the server to send different data on the
// second request. A queryparam should be able to implement this.
it.skip('should apply scope to bindings in new list items', async () => {
const liveListChildren = await controller.findElements(
'#liveListItems > *'
);
const liveListChildren =
await controller.findElements('#liveListItems > *');
await expect(liveListChildren.length).to.equal(1);

const existingItem = await controller.findElement('#liveListItem1');
Expand Down
5 changes: 2 additions & 3 deletions test/e2e/test-amp-bind-state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@ describes.endtoend(
// TODO(cvializ, choumx): Update server to have an endpoint that
// would test the infinite-loop blocking behavior
it.skip('should not loop infinitely if updates change its src binding', async () => {
const changeAmpStateSrcButton = await controller.findElement(
'#changeAmpStateSrc'
);
const changeAmpStateSrcButton =
await controller.findElement('#changeAmpStateSrc');
const setState = await controller.findElement('#setState');
const ampState = await controller.findElement('#ampState');

Expand Down
Loading