🏗 Attempt to execute the upload command to R2 up to seven times #39372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estherkim
approved these changes
Aug 15, 2023
|
Still getting intermittent failures. Screenshot from today, Aug 29 |
|
Not really sure what else to try. Right now file uploads are being parallelized, I can try to make them sequential. That would probably mean taking a long time to upload, but I guess we don't care about that too much since it's a nightly job? wdyt? |
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're getting repeated failures for the job that uploads nightly builds to Cloudflare's R2. This PR updates the S3 client library we use and increases the number of attempts from (the default) 3 to 7 attempts, because I don't have better ideas.
Tag-along change: change how we print progress, because CircleCI doesn't display background colours
This PR won't affect the currently failing nightly, but hopefully it'll work tomorrow!