Adding new vendor IncrementX

3p/integration.js

@@ -144,6 +144,7 @@ import {imedia} from '#ads/vendors/imedia';
 import {imobile} from '#ads/vendors/imobile';
 import {imonomy} from '#ads/vendors/imonomy';
 import {improvedigital} from '#ads/vendors/improvedigital';
+import {incrementx} from '#ads/vendors/incrementx';
 import {inmobi} from '#ads/vendors/inmobi';
 import {innity} from '#ads/vendors/innity';
 import {insticator} from '#ads/vendors/insticator';
@@ -430,6 +431,7 @@ register('imedia', imedia);
 register('imobile', imobile);
 register('imonomy', imonomy);
 register('improvedigital', improvedigital);
+register('incrementx', incrementx);
 register('industrybrains', industrybrains);
 register('inmobi', inmobi);
 register('innity', innity);

3p/vendors/incrementx.js

@@ -0,0 +1,12 @@
+// src/polyfills.js must be the first import.
+import '#3p/polyfills';
+
+import {register} from '#3p/3p';
+import {draw3p, init} from '#3p/integration-lib';
+
+import {incrementx} from '#ads/vendors/incrementx';
+
+init(window);
+register('incrementx', incrementx);
+
+window.draw3p = draw3p;

ads/_config.js

@@ -652,6 +652,11 @@ const adConfig = jsonConfiguration({
   },
   'improvedigital': {},
 
+  'incrementx': {
+    prefetch: 'https://cdn.incrementxserv.com/ixamp.js',
+    renderStartImplemented: true,
+  },
+
   'industrybrains': {
     prefetch: 'https://web.industrybrains.com/js/ads/async/show.js',
     preconnect: [

ads/vendors/incrementx.js

@@ -0,0 +1,14 @@
+import {validateData, writeScript} from '#3p/3p';
+
+/**
+ * @param {!Window} global
+ * @param {!Object} data
+ */
+export function incrementx(global, data) {
+  validateData(data, ['vzid']);
+  global.ixParam = data;
+  writeScript(
+    global,
+    'https://cdn.incrementxserv.com/ixamp.js'
+  );
+}

ads/vendors/incrementx.md

@@ -0,0 +1,20 @@
+# incrementx
+
+## Example
+
+```html
+ <amp-ad
+  width="320" 
+  height="50" 
+  type="incrementx" 
+  data-vzid="PNXW125273VB49B96">
+  </amp-ad>
+```
+
+## Configuration
+
+For configuration details and to generate your tags, please contact https://www.incrementx.com/contact-us.
+
+Supported parameters:
+
+-   `data-vzid`

examples/amp-ad/ads.amp.esm.html

@@ -169,6 +169,7 @@
         <option>imedia</option>
         <option>imobile</option>
         <option>imonomy</option>
+        <option>incrementx</option>
         <option>industrybrains</option>
         <option>inmobi</option>
         <option>innity</option>
@@ -1335,6 +1336,12 @@ <h2>Imedia</h2>
       data-positions='[{"id":"p1", "zoneId":"seznam.novinky.ikona2"}, {"id":"p2", "zoneId":"seznam.novinky.ikona"}]'>
   </amp-ad>
 
+  <h2>IncrementX</h2>
+  <amp-ad width="320" height="50" 
+  type="incrementx" 
+  data-vzid="PNXW125273VB49B96">
+ </amp-ad>
+
   <h2>Index Exchange Header Tag</h2>
   <amp-ad width="300" height="250"
       type="ix"

examples/amp-ad/ads.amp.html

@@ -285,6 +285,7 @@
         <option>imedia</option>
         <option>imobile</option>
         <option>imonomy</option>
+        <option>incrementx</option>
         <option>industrybrains</option>
         <option>inmobi</option>
         <option>innity</option>
@@ -1192,6 +1193,10 @@ <h2>Imedia</h2>
     data-positions='[{"id":"p1", "zoneId":"seznam.novinky.ikona2"}, {"id":"p2", "zoneId":"seznam.novinky.ikona"}]'>
   </amp-ad>
 
+  <h2>IncrementX</h2>
+  <amp-ad width="300" height="250" type="incrementx" data-vzid="PNXW125273VB49B96">
+  </amp-ad>
+
   <h2>Index Exchange Header Tag</h2>
   <amp-ad width="300" height="250" type="ix" data-ix-id="1" data-slot="/62650033/AMP_Example_Ad_Unit">
   </amp-ad>

extensions/amp-ad/amp-ad.md

@@ -365,6 +365,7 @@ See [amp-ad rules](validator-amp-ad.protoascii) in the AMP validator specificati
 -   [Imonomy](../../ads/vendors/imonomy.md)
 -   [Imedia](../../ads/vendors/imedia.md)
 -   [Improve Digital](../../ads/vendors/improvedigital.md)
+-   [IncrementX](../../ads/vendors/incrementx.md)
 -   [Insticator](../../ads/vendors/insticator.md)
 -   [InsurAds](../../ads/vendors/insurads.md)
 -   [Index Exchange](../../ads/vendors/ix.md)

validator/testdata/feature_tests/ads.html

@@ -124,6 +124,7 @@
         <option>ibillboard</option>
         <option>imobile</option>
         <option>imedia</option>
+        <option>incrementx</option>
         <option>industrybrains</option>
         <option>inmobi</option>
         <option>ix</option>
@@ -804,6 +805,10 @@ <h2>Imedia</h2>
       data-positions='[{"id":"p1", "zoneId":"seznam.novinky.ikona2"}, {"id":"p2", "zoneId":"seznam.novinky.ikona"}]'>
   </amp-ad>
 
+  <h2>IncrementX</h2>
+  <amp-ad width="320" height="50" type="incrementx" data-vzid="PNXW125273VB49B96">
+  </amp-ad>
+
   <h2>Industrybrains</h2>
   <amp-ad width="300" height="250"
       type="industrybrains"

validator/testdata/feature_tests/ads.out

@@ -125,6 +125,7 @@ PASS
 |          <option>ibillboard</option>
 |          <option>imobile</option>
 |          <option>imedia</option>
+|          <option>incrementx</option>
 |          <option>industrybrains</option>
 |          <option>inmobi</option>
 |          <option>ix</option>
@@ -805,6 +806,12 @@ PASS
 |        data-positions='[{"id":"p1", "zoneId":"seznam.novinky.ikona2"}, {"id":"p2", "zoneId":"seznam.novinky.ikona"}]'>
 |    </amp-ad>
 |
+|    <h2>IncrementX</h2>
+|    <amp-ad width="320" height="50"
+|        type="incrementx"
+|        data-vzid="PNXW125273VB49B96"
+|    </amp-ad>
+|
 |    <h2>Industrybrains</h2>
 |    <amp-ad width="300" height="250"
 |        type="industrybrains"