✨ Brid player support for child JSON config #38984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @alanorozco! These files were changed: |
erwinmombay
requested review from
erwinmombay,
powerivq and
ychsieh
and removed request for
nainar
|
@grajzer are you affiliated with brid? |
powerivq
approved these changes
May 31, 2023
erwinmombay
reviewed
May 31, 2023
| const configElement = doc.createElement('script'); | ||
| configElement.setAttribute('type', 'application/json'); | ||
| if (typeof config == 'string') { | ||
| configElement.textContent = config; |
There was a problem hiding this comment.
eozmen410 do we need to make this assignment trusted types compatible?
|
@erwinmombay Yes, I work in Brid and I made all previous changes to this component. |
|
Hi @erwinmombay please let me know if anything else is needed in regards to this, or when can we expect this change to go live. |
|
@grajzer apologies for late response.could you rebase and push the code out again. trying to get this green to merge |
|
|
|
Hi @erwinmombay, everything is updated now. |
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
* Brid player support for child JSON config * Brid player fix lint errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for providing additional config using child JSON.