Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume validator tests by using bazel 5 #38688

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Conversation

antiphoton
Copy link
Member

@antiphoton antiphoton commented Feb 24, 2023

Fix #38610

@amaltas amaltas self-requested a review February 24, 2023 00:31
@antiphoton antiphoton marked this pull request as ready for review February 24, 2023 00:31
@amp-owners-bot amp-owners-bot bot requested a review from estherkim February 24, 2023 00:31
@antiphoton
Copy link
Member Author

@estherkim
The percy/amphtml test is flaky and failing. Please review the visual diff. I don't have the permission the review it in percy.io.

@estherkim
Copy link
Collaborator

@estherkim The percy/amphtml test is flaky and failing. Please review the visual diff. I don't have the permission the review it in percy.io.

Done!

@antiphoton antiphoton merged commit 13cfe7f into ampproject:main Feb 27, 2023
@antiphoton antiphoton deleted the bazel5 branch February 27, 2023 21:13
@ampprojectbot
Copy link
Member

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

  • If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
  • If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
  • If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
  • If unsure, @-mention ampproject/wg-approvers

@estherkim
Copy link
Collaborator

Hi @antiphoton - looks like validator tests fail on main. Is Bazel installed correctly?

https://app.circleci.com/pipelines/github/ampproject/amphtml/26972/workflows/b06e6a83-8de3-43f4-bd83-e83dd6153bfc/jobs/564933

@estherkim
Copy link
Collaborator

another ping @antiphoton, @amaltas - a failure on main is blocking nightly cuts, which will prevent a new beta for next week's release cycle.

This possibly wasn't working before merging. I don't see amp validator-cpp being run in this PR's checks :/ that's on infra for missing the build target
https://app.circleci.com/pipelines/github/ampproject/amphtml/26964/workflows/78253ef9-8f46-45c2-a6ac-ddd7b8df12f4/jobs/564510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unskip validator-cpp tests
4 participants