🚮 Remove prebidappnexus RTC Vendor

[SyntaxNode]

Hi. I'm from Xandr/AppNexus.

The prebidappnexus RTC vendor is deprecated in favor of prebidappnexuspsp. Cleaning up our integration now that that publishers have migrated to our new vendor code.

[amp-owners-bot]

Hey @smart-adserver! These files were changed:

extensions/amp-ad-network-smartadserver-impl/0.1/test/test-amp-ad-network-smartadserver-impl.js

[SyntaxNode]

@smart-adserver Not sure why your tests reference prebidappnexus, but we'll need to update them. I proposed to move them to use prebidappnexuspsp, but please let me know what you prefer to do.

[krzysztofequativ]

@SyntaxNode, it's ok, you can update them to use prebidappnexuspsp.

[SyntaxNode]

CircleCI failed on:

checks.js Running amp check-links --local_changes...
[20:33:30] Using task file project/amp.js
[20:33:30] Starting 'check-links'...
[20:33:32] [✖] https://highfivve.com (0)
[20:33:32] ERROR: Possible dead link(s) found in extensions/amp-a4a/rtc-publisher-implementation-guide.md
[20:33:32] SUCCESS: All links in extensions/amp-a4a/rtc-documentation.md are alive.
[20:33:32] ERROR: Please update the dead link(s) in these files: extensions/amp-a4a/rtc-publisher-implementation-guide.md
[20:33:32] NOTE 1: Valid links that don't resolve during CI can be ignored via ignorePatterns in build-system/tasks/check-links.js.
[20:33:32] NOTE 2: Links that aren't meant to resolve to a real webpage can be exempted from this check by surrounding them with backticks (`).
[20:33:32] Finished 'check-links' after 2s

... but https://highfivve.com is accessible. ¯\_(ツ)_/¯

[powerivq]

#38661 @SyntaxNode We are fixing that failure. Will let you know when to rebase.

[powerivq]

@SyntaxNode The fix is in. Feel free to rebase against the latest main branch.

[SyntaxNode]

Thanks @powerivq. Rebased and am getting two test failures which seem unrelated to my changes.

amp-ad-network-doubleclick-impl#getAdUrl unit test

amp-base-carousel - vertical orientation end to end test. Perhaps this is just a timing issue? I found this comment on the test case: TODO(wg-bento, #24195): getScrollingElement does not always find element in time.

[ampprojectbot]

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

• If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
• If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
• If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
• If unsure, @-mention ampproject/wg-approvers