Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Remove unused CLI arguments related to Closure Compiler #38001

Merged
merged 3 commits into from
Apr 4, 2022
Merged

🏗 Remove unused CLI arguments related to Closure Compiler #38001

merged 3 commits into from
Apr 4, 2022

Conversation

alanorozco
Copy link
Member

No description provided.

@alanorozco alanorozco requested review from rsimha and rileyajones April 1, 2022 21:42
rsimha
rsimha approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the instances mentioned here as well?

amphtml/docs/testing.md

Lines 406 to 410 in c850f97

Here's an example for `amp dist --closure_concurrency=1`:
```sh
npx 0x -o node_modules/.bin/amp dist --closure_concurrency=1
```

@alanorozco alanorozco merged commit da680e9 into ampproject:main Apr 4, 2022
@alanorozco alanorozco deleted the arg branch April 4, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

@rileyajones rileyajones rileyajones approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alanorozco @rsimha @rileyajones @ampprojectbot