Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support --bento_only option in unit tests #37935

Merged
merged 1 commit into from
Mar 23, 2022
Merged

support --bento_only option in unit tests #37935

merged 1 commit into from
Mar 23, 2022

Conversation

kvchari
Copy link
Contributor

@kvchari kvchari commented Mar 22, 2022

  • create separate init-tests script for bento tests
  • separates bento unit testing files from other unit files
  • adds bento-specific unit testing utilities
  • updates defineElement() fns to accept a window attribute (useful for testing)

@kvchari
support --bento_only option in unit tests
f861c18 
* create separate init-tests script for bento tests
* separates bento unit testing files from other unit files
* adds bento-specific unit testing utilities
* updates defineElement() fns to accept a window attribute (useful for testing)
@kvchari kvchari merged commit 8614666 into ampproject:main Mar 23, 2022
@kvchari kvchari deleted the support-bento-only branch March 23, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileyajones rileyajones rileyajones approved these changes

@alanorozco alanorozco Awaiting requested review from alanorozco

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kvchari @rileyajones @ampprojectbot