Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [amp-ad broadstreetads] Replaced default value for initUrl #37814

Merged

Conversation

stevegardiner26
Copy link
Contributor

This PR updates the URL to our initialization script to a more recent/widely used version for the default value.

@amp-owners-bot amp-owners-bot bot requested a review from calebcordry March 2, 2022 21:52
@CLAassistant
Copy link

CLAassistant commented Mar 2, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for maintaining this!

@calebcordry calebcordry enabled auto-merge (squash) March 2, 2022 22:48
auto-merge was automatically disabled March 3, 2022 12:06

Head branch was pushed to by a user without write access

@stevegardiner26
Copy link
Contributor Author

Hey @calebcordry, just a note I fixed a lint error and then I saw the note about auto-merge. Anything I need to do?

@calebcordry calebcordry merged commit 8db1437 into ampproject:main Mar 4, 2022
@calebcordry
Copy link
Member

Merged!

@ampprojectbot
Copy link
Member

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

  • If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
  • If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
  • If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
  • If unsure, @-mention ampproject/wg-approvers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants