Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Use a shared tsconfig.base.json #37215

Merged
merged 8 commits into from
Dec 14, 2021
Merged

♻️ Use a shared tsconfig.base.json #37215

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c852678
Use a shared tsconfig.base.json
rcebulko Dec 14, 2021
05d10e7
Reverse tsconfig dependencies,
rcebulko Dec 14, 2021
638be56
Update eslint import resolver
rcebulko Dec 14, 2021
305912c
Add third_party in root
rcebulko Dec 14, 2021
2e246dd
Let wg-performance own tsconfig base
rcebulko Dec 14, 2021
dcbc6e2
Lint fix and remove extra extends
rcebulko Dec 14, 2021
4346d7f
Base can only contain passing paths
rcebulko Dec 14, 2021
4158d40
Lint fixes
rcebulko Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reverse tsconfig dependencies,
  • Loading branch information
@rcebulko
rcebulko committed Dec 14, 2021
commit 05d10e75187dac9deff80bc01edb0505feff0bd2
3 changes: 1 addition & 2 deletions src/core/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"extends": "../tsconfig.base.json",

"extends": "../../tsconfig.base.json",
"include": ["**/*.js", "**/*.d.ts"],
}
11 changes: 10 additions & 1 deletion src/tsconfig.base.json → tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
"extends": "../tsconfig.json",

"compilerOptions": {
"allowJs": true,
"checkJs": true,
"noEmit": true,
"downlevelIteration": true,
"target": "esnext",
"moduleResolution": "node",
Expand Down Expand Up @@ -38,5 +40,12 @@
}
},

"include": [],
"exclude": [
"**/build/**",
"**/dist/**",
"**/dist.*/**",
"**/node_modules/**",
"**/third_party/**",
"**/*.extern.js"
]
}
13 changes: 2 additions & 11 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
{
"extends": "./tsconfig.base.json",
"compilerOptions": {
"allowJs": true,
"baseUrl": ".",
"outDir": "dist",
"noEmit": true,

"paths": {
"#3p/*": ["./3p/*"],
Expand Down Expand Up @@ -35,13 +34,5 @@
}
},

"include": ["src", "3p", "ads", "extensions", "test", "testing"],
"exclude": [
"**/build/**",
"**/dist/**",
"**/dist.*/**",
"**/node_modules/**",
"**/third_party/**",
"**/*.extern.js"
]
"include": ["src", "3p", "ads", "extensions", "test", "testing"]
}