Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Use single bazel workspace for validator #37131

Merged
merged 3 commits into from
Dec 13, 2021
Merged

♻️ Use single bazel workspace for validator #37131

merged 3 commits into from
Dec 13, 2021

Conversation

antiphoton
Copy link
Member

@antiphoton antiphoton commented Dec 6, 2021 •
edited
Loading

  • Remove workspace files in validator/cpp/**, and combine them into the validator root folder.
  • Change bazel build dependency paths.

@antiphoton antiphoton force-pushed the single_workspace branch 6 times, most recently from 685d629 to b4867aa Compare December 7, 2021 00:11
@antiphoton antiphoton marked this pull request as ready for review December 13, 2021 20:33
@amp-owners-bot amp-owners-bot bot requested a review from rileyajones December 13, 2021 20:34
@amp-owners-bot
Copy link

amp-owners-bot bot commented Dec 13, 2021 •
edited by ampprojectbot
Loading

Hey @ampproject/wg-caching! These files were changed:

validator/.bazelrc
validator/.gitignore
validator/WORKSPACE
validator/cpp/engine/BUILD
validator/cpp/engine/WORKSPACE
validator/cpp/engine/embed_data.bzl
validator/cpp/engine/error-formatter.cc
validator/cpp/engine/error-formatter.h
validator/cpp/engine/error-formatter_test.cc
validator/cpp/engine/keyframes-parse-css.cc
validator/cpp/engine/keyframes-parse-css.h
validator/cpp/engine/keyframes-parse-css_test.cc
+107 more

@antiphoton antiphoton changed the title ♻️ Use single workspace for validator ♻️ Use single bazel workspace for validator Dec 13, 2021
honeybadgerdontcare
honeybadgerdontcare approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@honeybadgerdontcare honeybadgerdontcare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rileyajones
rileyajones approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@rileyajones rileyajones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for build-system change

@antiphoton antiphoton merged commit 9b8d9f4 into ampproject:main Dec 13, 2021
@antiphoton antiphoton deleted the single_workspace branch December 13, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileyajones rileyajones rileyajones approved these changes

@honeybadgerdontcare honeybadgerdontcare honeybadgerdontcare approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antiphoton @honeybadgerdontcare @rileyajones @ampprojectbot