Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Pass gdpr_consent and addtl_consent to IMA URL #37036

Merged
merged 6 commits into from
May 25, 2022
Merged

✨ Pass gdpr_consent and addtl_consent to IMA URL #37036

merged 6 commits into from
May 25, 2022

Conversation

alanorozco
Copy link
Member

@alanorozco alanorozco commented Nov 23, 2021 •
edited
Loading

@alanorozco alanorozco marked this pull request as ready for review January 11, 2022 19:18
@alanorozco alanorozco removed the request for review from rbeckthomas May 24, 2022 17:34
powerivq
powerivq requested changes May 25, 2022
View reviewed changes
Copy link
Contributor

@powerivq powerivq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to cycle the approval.

ads/google/ima/ima-video.js Show resolved Hide resolved
@alanorozco alanorozco merged commit 3b136ee into ampproject:main May 25, 2022
@alanorozco alanorozco deleted the ima-gdpr-string branch May 25, 2022 17:44
@ampprojectbot
Copy link
Member

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

  • If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
  • If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
  • If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
  • If unsure, @-mention ampproject/wg-approvers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerivq powerivq powerivq approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanorozco @ampprojectbot @powerivq