Add optional static enum lint #36759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @erwinmombay! These files were changed: |
jridgewell
force-pushed
the
static-enum
branch
from
290a5da to
56e8ceb
Compare
jridgewell
force-pushed
the
static-enum
branch
from
232175b to
f98ebb6
Compare
samouri
reviewed
Nov 4, 2021
build-system/eslint-rules/enums.js
Outdated
| if (callee.type === 'Identifier') { | ||
| const {name} = callee; | ||
| if ( | ||
| name === 'isEnumValue' // || |
There was a problem hiding this comment.
either:
- a) remove comments? same for lower down ones
- b) add a TODO line w/ a small explanation of why this is here
jridgewell
commented
Nov 4, 2021
build-system/eslint-rules/enums.js
Outdated
| if (callee.type === 'Identifier') { | ||
| const {name} = callee; | ||
| if ( | ||
| name === 'isEnumValue' // || |
samouri
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional enum linter that ensures that an enum is only used in a statically DCE-able way. Enums opt-into this behavior by using the
_Enumsuffix in their name.Depends on #36755
Partial for #36754