🐛 [amp-script] skip sha384 check for cross-origin scripts in sandboxed mode #36618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
reviewed
Oct 27, 2021
| 'alert(1)' | ||
| ) | ||
|
|
||
| service.checkSha384.withArgs('alert(1)').resolves() |
There was a problem hiding this comment.
This function should never be called, so we don't need to stub it
Suggested change
| service.checkSha384.withArgs('alert(1)').resolves() |
samouri
reviewed
Oct 27, 2021
| element.setAttribute('src', 'https://bar.example/bar.js') | ||
| element.setAttribute('sandboxed', '') | ||
|
|
||
| script.buildCallback() |
There was a problem hiding this comment.
buildCallback returns a promise, so you'll need to await it
Suggested change
| script.buildCallback() | |
| await script.buildCallback() |
zshnr
force-pushed
the
fix-csp-check-sandboxed-mode
branch
from
4799504 to
98ea7cc
Compare
zshnr
changed the title
samouri
approved these changes
Nov 2, 2021
|
Congratulations @zshnr on your first AMP PR 🎉 |
|
Thanks for all your help @samouri !! 😄 |
rileyajones
pushed a commit
to rileyajones/amphtml
that referenced
this pull request
Nov 4, 2021
…d mode (ampproject#36618) * skips sha384 check for remote scripts in sandboxed mode * update unit tests for amp-script * lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Skips the CSP hash check for a cross-origin source passed to
amp-scriptsince this is one of the features ofsandboxedmode introduced in PR #33643.Fixes #36614