Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AMP_CONFIG handling during build #35773

Merged
merged 11 commits into from
Aug 25, 2021
Merged

Improve AMP_CONFIG handling during build #35773

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d980d41
applyAmpConfig: also update sourcemaps
samouri Aug 23, 2021
9b0b698
no stone unturned: AMP_CONFIG should be part of the wrapper
samouri Aug 23, 2021
6d76251
update comments
samouri Aug 23, 2021
527ffae
update comment + fix bug
samouri Aug 23, 2021
60e63da
another bugfix
samouri Aug 23, 2021
4408bb9
allow newline between ; and AMP_CONFIG
samouri Aug 23, 2021
b5f2a19
retain logs for dist|build
samouri Aug 25, 2021
52f45c7
smol clean
samouri Aug 25, 2021
836b610
Update build-system/tasks/prepend-global/index.js
samouri Aug 25, 2021
3794548
Update build-system/tasks/prepend-global/index.js
samouri Aug 25, 2021
1600b87
target --> filename
samouri Aug 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update comments
  • Loading branch information
@samouri
samouri committed Aug 25, 2021
commit 6d7625144aaa21f0c459cbea8b147036d935581f
8 changes: 2 additions & 6 deletions build-system/tasks/prepend-global/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,14 +199,10 @@ async function getConfig(

/**
* Given a target, retrieves the appropriate AMP_CONFIG string to prepend.
* Returns an empty string
* Writes AMP_CONFIG to a runtime file. Optionally enables localDev mode and
* fortesting mode. Called by "amp build" and "amp dist" while building
* various runtime files.
*
* Returns an empty string if no AMP_CONFIG is necessary.
*
* @param {string} filename the file being operated on.
* @param {Object} options Whether or not to enable testing mode.
* @param {Object} options
* @return {!Promise<string>}
*/
async function getAmpConfigForFile(filename, options) {
Expand Down