Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚮 Remove IE Support via Polyfills and Conditional Statements #35317

Merged
merged 17 commits into from
Aug 25, 2021
Merged

🚮 Remove IE Support via Polyfills and Conditional Statements #35317

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a0d2d0f
Since we are not using the data, lets remove it
kristoferbaxter Jul 20, 2021
f799318
Remove all isIE checks and polyfills only used by IE
kristoferbaxter Jul 20, 2021
7747cf6
Remove URL changes
kristoferbaxter Aug 2, 2021
3d07401
Fix for merge conflicts
kristoferbaxter Aug 2, 2021
9ce3906
Integration tests were looking for IE specifics
kristoferbaxter Aug 2, 2021
8e77656
remove transparent img, and ie tests
kristoferbaxter Aug 2, 2021
08f17e7
Skip all tests on IE, this functionality will be removed by the infra…
kristoferbaxter Aug 2, 2021
d6a6d55
try using user agent directy in test configuration
kristoferbaxter Aug 3, 2021
073f4c8
Fix
kristoferbaxter Aug 3, 2021
b2bc374
Feedback on describe tests not needing configuration now
kristoferbaxter Aug 3, 2021
e51685e
Merge branch 'main' of github.com:ampproject/amphtml into ie-check-re…
kristoferbaxter Aug 4, 2021
29660fd
Merge with latest main
kristoferbaxter Aug 19, 2021
9f8a0b0
Remove unused files again
kristoferbaxter Aug 19, 2021
b7987ab
Merge branch 'main' of github.com:ampproject/amphtml into ie-check-re…
kristoferbaxter Aug 20, 2021
966c78f
Merge branch 'main' of github.com:ampproject/amphtml into ie-check-re…
kristoferbaxter Aug 20, 2021
9c05c47
Fix build before main is repaired
kristoferbaxter Aug 20, 2021
a040340
Merge branch 'main' of github.com:ampproject/amphtml into ie-check-re…
kristoferbaxter Aug 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Feedback on describe tests not needing configuration now
  • Loading branch information
@kristoferbaxter
kristoferbaxter committed Aug 3, 2021
commit b2bc374a363d16089948438df63076252c9530a2
6 changes: 3 additions & 3 deletions test/unit/core/dom/layout/test-layout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,7 @@ describes.realWin('ampshared.css', {amp: true}, function (env) {
doc.body.appendChild(element);
});

describe.configure().run('overflow', function () {
describe('overflow', function () {
let overflow;

beforeEach(() => {
Expand Down Expand Up @@ -717,7 +717,7 @@ describes.realWin('Layout: aspect-ratio CSS', {amp: true}, function (env) {
resetShouldUseAspectRatioCssForTesting();
});

describe.configure().run('aspect-ratio not supported', function () {
describe('aspect-ratio not supported', function () {
before(function () {
if (CSS.supports('aspect-ratio: 1/1')) {
this.skipTest();
Expand Down Expand Up @@ -750,7 +750,7 @@ describes.realWin('Layout: aspect-ratio CSS', {amp: true}, function (env) {
});
});

describe.configure().run('aspect-ratio supported', function () {
describe('aspect-ratio supported', function () {
before(function () {
if (!CSS.supports('aspect-ratio: 1/1')) {
this.skipTest();
Expand Down