🏗 Parallelizes execution of unit tests and e2e test on CircleCI #35227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrozenberg
force-pushed
the
circleci-unit-parallelism
branch
30 times, most recently
from
254e36f to
fed1d52
Compare
danielrozenberg
force-pushed
the
circleci-unit-parallelism
branch
from
d82996a to
0490bf6
Compare
rsimha
reviewed
Jul 20, 2021
rsimha
reviewed
Jul 20, 2021
.circleci/config.yml
Outdated
| 'All Unit Tests': | ||
| executor: | ||
| name: amphtml-large-executor | ||
| parallelism: 16 |
There was a problem hiding this comment.
I was suggesting going below 16, not above. For posterity, could you share links that show the total duration and the total CPU usage for 4, 8, and 16 respectively (and any other parallelism factors you think are worth trying)?
danielrozenberg
force-pushed
the
circleci-unit-parallelism
branch
from
66ee65b to
62c4369
Compare
rileyajones
approved these changes
Jul 20, 2021
danielrozenberg
force-pushed
the
circleci-unit-parallelism
branch
2 times, most recently
from
c2083d1 to
044b444
Compare
Co-authored-by: Raghu Simha <rsimha@amp.dev>
danielrozenberg
force-pushed
the
circleci-unit-parallelism
branch
from
1f366da to
e1273f6
Compare
rsimha
approved these changes
Jul 23, 2021
There was a problem hiding this comment.
This was a valiant effort, and the results in #35227 (comment) are very exciting. A ~30% reduction in running time for a ~10% increase in credits used is an excellent tradeoff.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
⛓️emoji in their name to indicate that they're paralellized--local_changesinto a separate job which is a prerequisite to the (now renamed)All Unit TestsjobAll Unit Testswhen running on push builds, as it has no meaning outside of pull requests