✨ Add support for Wunderkind Auto AMP Ads #35222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Image Polls (#35205) * Add fill animation * Add bubble post-selection animation * Move background color percentage fill to post selection styles
|
Hey @gmajoulet, @mszylkowski! These files were changed: |
calebcordry
reviewed
Jul 14, 2021
extensions/amp-auto-ads/0.1/test/test-wunderkind-network-config.js
Outdated
Show resolved
Hide resolved
calebcordry
reviewed
Jul 15, 2021
extensions/amp-auto-ads/0.1/test/test-wunderkind-network-config.js
Outdated
Show resolved
Hide resolved
calebcordry
approved these changes
Jul 19, 2021
|
@weirdian2k3 it looks like our CI is having trouble calculating the commit, could you sync to main? |
auto-merge was automatically disabled
July 20, 2021 13:31
Head branch was pushed to by a user without write access
@calebcordry I think I found the issue. CircleCI wasn't reporting the failure to Github, but there were test failures in CircleCI. I went ahead and fixed those and I think we may be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides support for
<amp-auto-ads type="wunderkind" />Closes #35207