💅 / 🏗 Create new binary for compiler #compiler #35137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcebulko
reviewed
Jul 7, 2021
| @@ -112,6 +112,15 @@ exports.jsBundles = { | |||
| includePolyfills: true, | |||
| }, | |||
| }, | |||
| 'compiler.js': { | |||
| srcDir: './src/compiler/', | |||
There was a problem hiding this comment.
🚲 🏚️ ing time! Do these binaries get served on the CDN?
There was a problem hiding this comment.
I believe so! In this case it would be at https://cdn.ampproject.org/compiler.js as the url.
Done! |
|
Hey @rcebulko! These files were changed: |
rcebulko
approved these changes
Jul 8, 2021
jridgewell
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Creates a new binary for the Bento Compiler project.
The first iteration acts as an identity function.
The purpose of this PR is to get bikeshedding out of the way re. the file location, name etc.
binary contents