Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync for validator/cpp/{engine,htmlparser} #35044

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

antiphoton
Copy link
Member

@antiphoton antiphoton commented Jun 25, 2021

Sync for validator/cpp/htmlparser
Sync for validator/cpp/engine

This PR syncs cl/378533243 for the two folders in one time, because neither can pass circle ci test by itself.

amaltas added 2 commits June 25, 2021 19:00
…src. This in addition to line/col already supported in htmlparser.

- Add support for recording number of words (num_terms) in a text node.

PiperOrigin-RevId: 378533243
…src. This in addition to line/col already supported in htmlparser.

- Add support for recording number of words (num_terms) in a text node.

PiperOrigin-RevId: 378533243
@antiphoton antiphoton changed the title [DO NOT MERGE] Test cl 378533243 Sync for validator/cpp/{engine,htmlparser} Jun 25, 2021
@antiphoton antiphoton marked this pull request as ready for review June 25, 2021 19:20
@amp-owners-bot
Copy link

amp-owners-bot bot commented Jun 25, 2021

Hey @ampproject/wg-caching! These files were changed:

validator/cpp/engine/parse-layout.cc
validator/cpp/engine/parse-layout.h
validator/cpp/engine/validator-internal.cc
validator/cpp/htmlparser/node.cc
validator/cpp/htmlparser/node.h
validator/cpp/htmlparser/parser.cc
validator/cpp/htmlparser/parser_test.cc
validator/cpp/htmlparser/token.h
validator/cpp/htmlparser/tokenizer.cc
validator/cpp/htmlparser/tokenizer.h
validator/cpp/htmlparser/tokenizer_test.cc

@antiphoton antiphoton requested a review from banaag June 25, 2021 19:20
@antiphoton antiphoton enabled auto-merge (squash) June 25, 2021 19:20
@antiphoton antiphoton merged commit 4eb375b into ampproject:main Jun 25, 2021
@antiphoton antiphoton deleted the cl_378533243 branch June 25, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants