🏗 🐛 ❄️ always check forbidden terms #34897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @rsimha! These files were changed: |
rsimha
approved these changes
Jun 16, 2021
rcebulko
reviewed
Jun 16, 2021
rileyajones
force-pushed
the
forbidden-terms-fix
branch
2 times, most recently
from
50a752d to
24089a5
Compare
rcebulko
reviewed
Jun 16, 2021
Co-authored-by: Raghu Simha <rsimha@amp.dev>
rileyajones
force-pushed
the
forbidden-terms-fix
branch
from
24089a5 to
3797520
Compare
rcebulko
approved these changes
Jun 16, 2021
rsimha
reviewed
Jun 16, 2021
Co-authored-by: Raghu Simha <rsimha@amp.dev>
rsimha
approved these changes
Jun 16, 2021
This was referenced Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#34887 demonstrated that the
forbidden-termsfile always needs to be checked by removing forbidden terms from files on the allowlist. Because the we runamp lint --local_changesin CI now the checks passed but then started failing on main.Checks run from bad PR
https://app.circleci.com/pipelines/github/ampproject/amphtml/11572/workflows/fa5345cd-0ebe-4663-b8a1-f5905a1b63da/jobs/183106
Future checks run on main
https://app.circleci.com/pipelines/github/ampproject/amphtml/11572/workflows/fa5345cd-0ebe-4663-b8a1-f5905a1b63da/jobs/183106