Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗Add #test and #testing to alias list #34853

Merged
merged 6 commits into from
Jun 15, 2021
Merged

🏗Add #test and #testing to alias list #34853

merged 6 commits into from
Jun 15, 2021

Conversation

rcebulko
Copy link
Contributor

@rcebulko rcebulko commented Jun 12, 2021 •
edited
Loading

Don't look at the files tab, look at the first commit: a9e25dc
The rest of the changes are just a result of amp lint --fix

@rcebulko rcebulko marked this pull request as ready for review June 12, 2021 00:57
@amp-owners-bot amp-owners-bot bot requested a review from kristoferbaxter June 12, 2021 00:57
@amp-owners-bot
Copy link

amp-owners-bot bot commented Jun 12, 2021 •
edited
Loading

Hey @alanorozco! These files were changed:

extensions/amp-3q-player/0.1/test/test-amp-3q-player.js

Hey @gmajoulet! These files were changed:

extensions/amp-story-interactive/0.1/test/test-amp-story-interactive-binary-poll.js
extensions/amp-story-interactive/0.1/test/test-amp-story-interactive-poll.js
extensions/amp-story-interactive/0.1/test/test-amp-story-interactive.js
extensions/amp-story/1.0/test/integration/test-amp-story-affiliate-link.js
extensions/amp-story/1.0/test/test-amp-story-media-query-service.js
extensions/amp-story/1.0/test/test-amp-story.js

Hey @mszylkowski! These files were changed:

extensions/amp-story-interactive/0.1/test/test-amp-story-interactive-binary-poll.js
extensions/amp-story-interactive/0.1/test/test-amp-story-interactive-poll.js
extensions/amp-story-interactive/0.1/test/test-amp-story-interactive.js

Hey @newmuis! These files were changed:

extensions/amp-story/1.0/test/integration/test-amp-story-affiliate-link.js
extensions/amp-story/1.0/test/test-amp-story-media-query-service.js
extensions/amp-story/1.0/test/test-amp-story.js

@rcebulko rcebulko enabled auto-merge (squash) June 12, 2021 01:00
@rcebulko
Copy link
Contributor Author

Don't look at the files tab, look at the first commit: a9e25dc
The rest of the changes are just a result of amp lint --fix

@rcebulko
Copy link
Contributor Author

@kristoferbaxter bumping this in your queue. Only "real" diff is a9e25dc

@rcebulko
Copy link
Contributor Author

rcebulko commented Jun 15, 2021 •
edited
Loading

Real diff: 7ee3e06...5d1885c

kristoferbaxter
kristoferbaxter approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@kristoferbaxter kristoferbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one nit and one question to validate things work.

@rcebulko
Copy link
Contributor Author

Verified tsconfig changes locally

@rcebulko rcebulko merged commit c228856 into ampproject:main Jun 15, 2021
@rcebulko rcebulko deleted the alias-test branch June 15, 2021 20:23
westonruter added a commit to westonruter/amphtml that referenced this pull request Jun 16, 2021
@westonruter
Merge branch 'main' of github.com:ampproject/amphtml into add/amp-fac…
a7e72f4 
…ebook-like-bento-version

* 'main' of github.com:ampproject/amphtml: (23 commits)
  `amp-story-desktop-one-panel` Update demo with usecases (ampproject#34867)
  🚮 Remove src/purifier.js rollup config (ampproject#34876)
  Validator Rollup (ampproject#34769)
  ✨ `amp-story-desktop-one-panel` Check UI type to get page dimension on tap (ampproject#34875)
  Refactor: move getRealChildNodes and getRealChildren to core (ampproject#34813)
  🏗📖 Fix some example files that do not validate (ampproject#34835)
  🏗Add `#test` and `#testing` to alias list (ampproject#34853)
  Add css files for missing components (ampproject#34861)
  Apply bulk transform to html tags (ampproject#34836)
  🐛 amp-ima-video: Fix duration label on livestreams (ampproject#34865)
  ♻️  Extract `applyFillContent` into a standalone function (ampproject#34858)
  Give script tag closing tag (ampproject#34832)
  🏗 Refinements to renovate config (ampproject#34862)
  Bento: Enable `SocialShare` for npm publishing (ampproject#34817)
  🏗 Use aliased paths in generated extensions (ampproject#34860)
  ✨ `amp-story-desktop-one-panel` Position distance="2" page below viewport (ampproject#34834)
  🏗 Set `wrapper` on generated Bento extensions (ampproject#34843)
  🧪[story-ads] Allow viewer to set progress bar segment experiment. (ampproject#34827)
  🏗 Allow extension bundles to specify their own wrapper (ampproject#34845)
  🏗🚀 Speed up validated example grouping ~45x (ampproject#34837)
  ...
@rcebulko rcebulko mentioned this pull request Jun 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoferbaxter kristoferbaxter kristoferbaxter approved these changes

@samouri samouri samouri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcebulko @kristoferbaxter @samouri