Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 [Story performance] Experiment to load first page assets before loading other pages to improve LCP #34846

Merged
merged 29 commits into from
Jul 12, 2021
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
1fca7ce
Added lcp, tests, etc
mszylkowski Jun 11, 2021
11c5ccb
Cleaned up
mszylkowski Jun 11, 2021
46ed6c0
Merge branch 'main' of github.com:ampproject/amphtml into px_firstpage
mszylkowski Jun 15, 2021
6d20a91
Added return
mszylkowski Jun 17, 2021
792ba51
Merge branch 'main' of github.com:ampproject/amphtml into px_firstpage
mszylkowski Jun 17, 2021
8595d55
Use webp
mszylkowski Jun 17, 2021
345f1bc
Fixed imports
mszylkowski Jun 17, 2021
4b397e3
Fixed page loading before distance set
mszylkowski Jun 17, 2021
b63c8a7
Fix isExperimentOn and overrideDistance
mszylkowski Jun 18, 2021
a6d2d9d
Removed log
mszylkowski Jun 18, 2021
080e7b0
Fixed setDistance on navigation
mszylkowski Jun 22, 2021
064bafd
Removed unused import / export
mszylkowski Jun 22, 2021
9a37526
Fix html checks
mszylkowski Jun 22, 2021
6e31458
Updated tests
mszylkowski Jun 23, 2021
ee43c1f
revert const to let
mszylkowski Jun 23, 2021
9c4602a
Update extensions/amp-story/1.0/amp-story.js
mszylkowski Jun 23, 2021
03d6e6c
Simplified preloadAll call
mszylkowski Jun 23, 2021
51bccf9
Removed comment
mszylkowski Jun 23, 2021
da3d7fc
Updated tests and removed getDistance
mszylkowski Jun 23, 2021
c87d3dc
Rely on store service
mszylkowski Jun 24, 2021
acbab68
Added csi experiment
mszylkowski Jun 24, 2021
57d67dc
Merge branch 'main' of github.com:ampproject/amphtml into px_firstpage
mszylkowski Jun 24, 2021
f3a9b94
Merge branch 'main' of github.com:ampproject/amphtml into px_firstpage
mszylkowski Jun 25, 2021
d261b82
Add comment and move experiment
mszylkowski Jul 1, 2021
ca67192
Split tests in compressed / uncompressed
mszylkowski Jul 2, 2021
3566ac6
Merge branch 'main' of github.com:ampproject/amphtml into px_firstpage
mszylkowski Jul 2, 2021
3de9ad7
Catch inside then
mszylkowski Jul 2, 2021
939f55e
Merge branch 'main' of github.com:ampproject/amphtml into px_firstpage
mszylkowski Jul 7, 2021
ba37419
Fixed test
mszylkowski Jul 7, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed comment
  • Loading branch information
mszylkowski committed Jun 23, 2021
commit 51bccf9769fe5dd84f21e9dcaf632049ccd39ab8
2 changes: 0 additions & 2 deletions extensions/amp-story/1.0/amp-story.js
Original file line number Diff line number Diff line change
Expand Up @@ -2266,8 +2266,6 @@ export class AmpStory extends AMP.BaseElement {
})
.then(preloadAllPages)
.catch();

// Load page with distance 0 first, and then load the other ones.
});
}

Expand Down