Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Migrate math and some DOM logic into core w/ type-checking #34550

Merged
merged 26 commits into from
May 26, 2021
Merged

♻️ Migrate math and some DOM logic into core w/ type-checking #34550

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
dd62361
Move utils/dom-fingerprint to core/dom/fingerprint
rcebulko May 25, 2021
db33f11
Fix imports in fingerprint.js
rcebulko May 25, 2021
37bb1e8
Move utils/date to core/dom/parse-date-attributes
rcebulko May 25, 2021
6e09b22
Improve types in parse-date-attributes
rcebulko May 25, 2021
c35f340
Move utils/dom-based-weakref to core/dom/weakref
rcebulko May 25, 2021
8ad8f5d
Update test names
rcebulko May 25, 2021
6764e5d
Add __AMP_WEAKREF_ID extern
rcebulko May 25, 2021
1a582f4
Move math, id-gen, layout-rect to core/math
rcebulko May 25, 2021
87a881c
Update types for layout-rect
rcebulko May 25, 2021
00591f5
Move get-html into core/dom
rcebulko May 25, 2021
5e8c729
Move isFiniteNumber into core/types
rcebulko May 25, 2021
319228e
Move document-ready to core
rcebulko May 25, 2021
24cada4
Move web-components to core/dom
rcebulko May 26, 2021
5783320
Fix types in web-components
rcebulko May 26, 2021
cff1c55
Move dom streaming helpers to core/dom/stream
rcebulko May 26, 2021
6ac8851
Update imports of dom-fingerprint
rcebulko May 25, 2021
290a2e0
Update imports of parseDateAttrs
rcebulko May 25, 2021
c71ab34
Update (only) import of DomBasedWeakRef
rcebulko May 25, 2021
83add87
Update imports of math helpers
rcebulko May 25, 2021
111a6d3
Update imports of get-html
rcebulko May 25, 2021
2cf003b
Update imports of isFiniteNumber
rcebulko May 25, 2021
07d903a
Update imports of document-ready
rcebulko May 25, 2021
58ca08e
Update imports of web-components
rcebulko May 26, 2021
63834e5
Update imports of dom stream helpers
rcebulko May 26, 2021
4af5653
Update forbidden-terms
rcebulko May 26, 2021
dc2751d
Not nullable type
rcebulko May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update (only) import of DomBasedWeakRef
  • Loading branch information
@rcebulko
rcebulko committed May 26, 2021
commit c71ab34264a8ec3f294a67df6891afe974802294
2 changes: 1 addition & 1 deletion extensions/amp-video/0.1/flexible-bitrate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

import {DomBasedWeakRef} from '../../../src/utils/dom-based-weakref';
import {DomBasedWeakRef} from '../../../src/core/dom/weakref';
import {childElement, childElementsByTag} from '../../../src/dom';
import {dev, devAssert} from '../../../src/log';
import {isExperimentOn} from '../../../src/experiments';
Expand Down