Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Support img element #34028

Merged
merged 58 commits into from
May 20, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
486988e
Allow IMG so long as it contains a loading attribute
kristoferbaxter Apr 27, 2021
5bc0093
Make width and height mandatory
kristoferbaxter Apr 27, 2021
afe3dd5
Move method from within AMP.BaseElement to src/core/dom since it must…
kristoferbaxter Apr 27, 2021
3412e94
Update validator output
kristoferbaxter Apr 27, 2021
0627d01
Mid way stopping point on amp-lightbox-gallery cloneLightboxableElement_
kristoferbaxter Apr 27, 2021
ce7e2ae
Lightbox gallery now supports image elements
kristoferbaxter Apr 27, 2021
bf9daa8
Use Sets instead of objects
kristoferbaxter Apr 27, 2021
4d6a070
PR feedback on name of utility and usage of other utilities
kristoferbaxter Apr 27, 2021
7b12a26
Merge branch 'main' of github.com:ampproject/amphtml into support-img
kristoferbaxter Apr 28, 2021
c2aff18
lightbox had a bad reference
kristoferbaxter Apr 29, 2021
0259f76
Merge latest main
kristoferbaxter Apr 29, 2021
54d8fdd
Merge branch 'main' of github.com:ampproject/amphtml into support-img
kristoferbaxter Apr 29, 2021
538c254
Spy on the right thing now
kristoferbaxter Apr 29, 2021
9b7d7a7
Remove validator changes for a later step
kristoferbaxter Apr 29, 2021
0f732e2
Carriage returns at the end of the out files for the validator
kristoferbaxter Apr 29, 2021
c2bb89a
Updated carriage returns at end of files
kristoferbaxter Apr 29, 2021
04b82e5
Update comments
kristoferbaxter May 5, 2021
dffe889
Move auto lightbox to loadPromise
kristoferbaxter May 5, 2021
e174c68
Remove Set in amp-auto-lightbox
kristoferbaxter May 5, 2021
4592e36
Remove set in amp-image-lightbox
kristoferbaxter May 5, 2021
39006bd
Remove logic specific to amp-img for the img path
kristoferbaxter May 5, 2021
0d4eb49
Additional fixes for Set usage
kristoferbaxter May 6, 2021
59455c9
Merge branch 'main' of github.com:ampproject/amphtml into support-img
kristoferbaxter May 6, 2021
8937bdc
test for supporting img on amp-image-lightbox
kristoferbaxter May 6, 2021
90ff796
Add tests for propagate attributes helper and fix usage in iframe-video
kristoferbaxter May 6, 2021
a538b4c
Additional fixes for propagateAttributes from AMPElements
kristoferbaxter May 6, 2021
5705f71
Merge branch 'main' of github.com:ampproject/amphtml into support-img
kristoferbaxter May 6, 2021
20127b1
Merge conflicts
kristoferbaxter May 11, 2021
c2d3bf5
Bad merge
kristoferbaxter May 11, 2021
0b63e1a
pass ampdoc in Criteria so its not obtained from an HTMLElement
kristoferbaxter May 11, 2021
519fa81
change order of arguments to reduce test rewriting for Criteria
kristoferbaxter May 11, 2021
1130dd1
Fix types in propagate attributes
kristoferbaxter May 12, 2021
d31c757
Prettier formatting
kristoferbaxter May 12, 2021
fade270
Merge branch 'main' of github.com:ampproject/amphtml into support-img
kristoferbaxter May 12, 2021
c4292e8
different prettier versions
kristoferbaxter May 12, 2021
bb8a2d9
Merge branch 'main' of github.com:ampproject/amphtml into support-img
kristoferbaxter May 13, 2021
21a8dc2
update core utility with improved typing from below
kristoferbaxter May 13, 2021
15c5b58
Address part of Alans feedback
kristoferbaxter May 13, 2021
acbfd3a
types
kristoferbaxter May 13, 2021
8f7fbfc
remove toLowerCase on tagName
kristoferbaxter May 13, 2021
b448094
Test changes from PR feedback (and applied elsewhere in the file)
kristoferbaxter May 13, 2021
7e8d6a9
Add support for native HTMLImageElements to amp-image-slider
kristoferbaxter May 14, 2021
f90f409
Add test using HTMLImageElements
kristoferbaxter May 14, 2021
643aef7
Revert changes to gestures for a later PR
kristoferbaxter May 14, 2021
1cdc0ec
Continued progress, pan zoom works and lightbox gallery is underway
kristoferbaxter May 18, 2021
a46e1ee
Merge in latest main
kristoferbaxter May 18, 2021
222d247
LayoutScheduled for amp-carousel 0.1 when unlayout happening
kristoferbaxter May 19, 2021
a6885da
Remove image support for amp-image-viewer for a future PR
kristoferbaxter May 19, 2021
1f6492d
Image Viewer no longer needs to exclude itself from using loadPromise…
kristoferbaxter May 19, 2021
83a0a07
Remove console logging for carousel debugging:
kristoferbaxter May 19, 2021
02fbc8c
Remove breaks in parsing of children for amp-image-slider
kristoferbaxter May 19, 2021
05d95d5
No need to provide an empty array for the Set constructor
kristoferbaxter May 19, 2021
033f3aa
Remaining console
kristoferbaxter May 19, 2021
d8f19fe
Nit
kristoferbaxter May 19, 2021
d8fd326
Remove more intermediary state changes
kristoferbaxter May 19, 2021
343024c
Naming nit
kristoferbaxter May 20, 2021
ccb6010
Merge conflicts
kristoferbaxter May 20, 2021
61c93db
prettier formatting in test
kristoferbaxter May 20, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lightbox had a bad reference
  • Loading branch information
kristoferbaxter committed Apr 29, 2021
commit c2aff18b8fa90dea2d86f0e9b115be0a0ea66989
2 changes: 1 addition & 1 deletion extensions/amp-image-lightbox/0.1/amp-image-lightbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ import {
layoutRectLtwh,
moveLayoutRect,
} from '../../../src/layout-rect';
import {propagateAttributes} from '../../../src/core/dom/propagateAttributes';
import {propagateAttributes} from '../../../src/core/dom/propagate-attributes';
import {setStyles, toggle} from '../../../src/style';
import {srcsetFromElement} from '../../../src/srcset';

Expand Down
15 changes: 15 additions & 0 deletions test/unit/core/dom/test-propagate-attributes.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
/**
* Copyright 2021 The AMP HTML Authors. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS-IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/